Against maybe 80% of all players, I raise my sets on the flop. The ones I don't do it versus are the ones where they follow the basic pattern of "always cbet, barrel the turn only with air and monsters and check every other hand" - which is a common enough way to play for a lot of people that I think it comes out to about 1/5 - that I'm near certain of will play that way.
Against all the rest, just raise the flop when you have a set. Calling the flop and raising the turn is only better the times when he will VERY often bet again on the turn, because almost the only range that continues after your turn raise is the same that you stack off if you just raise the flop to begin with, but you get the added value of having him bluff a few extra dollars into you some of the time.
But for most opponents, those extra dollars won't make up even nearly enough to cover the immediate loss of raising the more passive opponents who will cbet the flop but not necessarily bet the turn with most hands (and there are a lot of those players). They'll call flop raises too often in general, though, and you REALLY hit the jackpot when they spazz out and think you're full of crap and 3-bet bluff shove. It doesn't happen often, but it's so valuable when it happens that it adds quite a few dollars of EV to raising the flop.
On this PARTICULAR flop, raising is mandatory versus 100% of opponents. With the straight and flushdraws available, there's a greater than average chance that he'll shove with a draw alternatively put YOU on a draw that not raising is borderline criminal. He'll shut down a lot of his value range on the turn if it's a third diamond and look to get to showdown cheaply. If you raise the flop, you can stack him when he's trying to get to showdown. If you don't raise the flop, you win half his stack as he's trying to play pot control - big difference.